-
Notifications
You must be signed in to change notification settings - Fork 529
Remove uv lock #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove uv lock #3840
Conversation
isaac-chung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about the consequences, but I'm willing to try it out.
|
I would really keep it. The lock file is there to communicate that this worked with exactly these dependencies. It helps us and others track problematic dependencies. From the docs:
We could consider using pylock.toml, but Maybe it is better to examine why it is so large and what we can do to reduce it |
|
Lock prevents us to test on latest versions to see problems before user will face them
We have a lot of conflict dependencies Lines 322 to 338 in 44e9b20
|
would be doable to just update it our test CI
Hmm I actually thought conflicting dependencies would reduce the solve time (fewer constraints), but it seems like literally half the file is conflicting dependencies. What the best approach to combat these? My current thought are:
|
This is opposite. They're increasing complexity by a lot astral-sh/uv#16779
I think we have a lot of packages and most of them are not maintained |
|
Seems like a solution might be to simplify the conflicting depencies: There is also a few of these which I am not sure why are there (model2vec and llm2vec seems odd). We can also set the environments (probably the way to go), e.g.: I could see us making a |
Yeah, if we want to keep support for these I think we need to figure out a decent approach |
uv.lockweights too much (10 mb on main and 25 mb on maeb) and with it really hard switching between branches. I think we can delete it for easier development