Fix error when using splattributes but no attributes were passed#68
Merged
Conversation
Contributor
Author
|
Seems there was already a test case for this case, but for passing to an element: https://github.com/rwjblue/ember-angle-bracket-invocation-polyfill/blob/master/tests/integration/components/angle-bracket-invocation-test.js#L442-L451 The test added here for a component was failing with that #67 error. |
rwjblue
approved these changes
May 5, 2019
Contributor
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Awesome work, thank you!
I'll try to merge + release once back at my computer (please remind me if not done in a day or so :P )...
Contributor
Author
|
@rwjblue gentle reminder! 😬 Also, would be awesome if you could have a look again some time at the other issue, specifically #65 (comment). |
rwjblue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67