Add/remove village admins in the admin screen#1903
Open
ashirley wants to merge 1 commit intoemfcamp:mainfrom
Open
Add/remove village admins in the admin screen#1903ashirley wants to merge 1 commit intoemfcamp:mainfrom
ashirley wants to merge 1 commit intoemfcamp:mainfrom
Conversation
lukegb
reviewed
Mar 9, 2026
|
|
||
| if user is None: | ||
| flash(f"No user found with email {user_email}") | ||
| elif VillageMember.query.filter(VillageMember.user == user).first() is not None: |
Contributor
There was a problem hiding this comment.
If they're a member of the village they're being added to as an admin, we should probably promote them (although I acknowledge that, at the moment, we only have admin-members-of-villages).
Although then that raises a 'what should deleting them' do question, so maybe it's better off leaving that one well alone.
Kunsi
reviewed
Mar 10, 2026
lukegb
force-pushed
the
village-admin-users
branch
from
32e6583 to
d1c99fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1684