Skip to content

Fix compiler warnings on ARM platform #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travishaagen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiler warnings on ARM platform #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions loguru.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ namespace loguru

static void escape(std::string& out, const std::string& str)
{
for (char c : str) {
for (signed char c : str) {
/**/ if (c == '\a') { out += "\\a"; }
else if (c == '\b') { out += "\\b"; }
else if (c == '\f') { out += "\\f"; }
Expand Down Expand Up @@ -1189,7 +1189,7 @@ namespace loguru
localtime_r(&sec_since_epoch, &time_info);

auto uptime_ms = duration_cast<milliseconds>(steady_clock::now() - s_start_time).count();
auto uptime_sec = uptime_ms / 1000.0;
auto uptime_sec = static_cast<double>(uptime_ms) / 1000.0;

char thread_name[LOGURU_THREADNAME_WIDTH + 1] = {0};
get_thread_name(thread_name, LOGURU_THREADNAME_WIDTH + 1, true);
Expand Down Expand Up @@ -1440,7 +1440,7 @@ namespace loguru
}
}
#if LOGURU_VERBOSE_SCOPE_ENDINGS
auto duration_sec = (now_ns() - _start_time_ns) / 1e9;
auto duration_sec = static_cast<double>(now_ns() - _start_time_ns) / 1e9;
#if LOGURU_USE_FMTLIB
auto buff = textprintf("{:.{}f} s: {:s}", duration_sec, LOGURU_SCOPE_TIME_PRECISION, _name);
#else
Expand Down Expand Up @@ -1653,7 +1653,7 @@ namespace loguru
return Text{STRDUP(str.c_str())};
}

Text ec_to_text(char c)
Text ec_to_text(signed char c)
{
// Add quotes around the character to make it obvious where it begin and ends.
std::string str = "'";
Expand Down