Remove printf usage from emmalloc.s and sbrk.s. NFC#26497
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 20, 2026
Merged
Remove printf usage from emmalloc.s and sbrk.s. NFC#26497sbc100 merged 1 commit intoemscripten-core:mainfrom
printf usage from emmalloc.s and sbrk.s. NFC#26497sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
printf usage from emmalloc.s and sbrk.s. NFC
I noticed some code size issues while working on emscripten-core#26489 and gemini tracked them down to usage of the `printf` symbol. It turns out that just referencing the printf (even if the referencing function is not used) in a used object file can lead code bloat due to the weak symbol mechanism used in musl to track stdio usage (see __stdout_used, etc).
tlively
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some code size issues while working on #26489 and gemini tracked them down to usage of the
printfsymbol.It turns out that just referencing the printf (even if the referencing function is not used) in a used object file can lead code bloat due to the weak symbol mechanism used in musl to track stdio usage (see __stdout_used, etc).