Handle AT_SYMLINK_NOFOLLOW in __syscall_faccessat#26500
Open
thiblahute wants to merge 1 commit intoemscripten-core:mainfrom
Open
Handle AT_SYMLINK_NOFOLLOW in __syscall_faccessat#26500thiblahute wants to merge 1 commit intoemscripten-core:mainfrom
thiblahute wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
The assertion in __syscall_faccessat only allowed AT_EACCESS, causing a crash when AT_SYMLINK_NOFOLLOW was passed (e.g. by GLib's g_local_file_query_exists which uses AT_EACCESS | AT_SYMLINK_NOFOLLOW). Accept AT_SYMLINK_NOFOLLOW and use it to control whether symlinks are followed during the path lookup.
sbc100
reviewed
Mar 20, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Thanks for working on this.
You you perhaps update the test/unistd/access.c test to cover this new code?
| path = SYSCALLS.getStr(path); | ||
| #if ASSERTIONS | ||
| assert(!flags || flags == {{{ cDefs.AT_EACCESS }}}); | ||
| assert(!flags || !(flags & ~({{{ cDefs.AT_EACCESS }}} | {{{ cDefs.AT_SYMLINK_NOFOLLOW }}}))); |
Collaborator
There was a problem hiding this comment.
I think maybe you can remove the !flags || prefix on this condition now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion in __syscall_faccessat only allowed AT_EACCESS, causing a crash when AT_SYMLINK_NOFOLLOW was passed (e.g. by GLib's g_local_file_query_exists which uses AT_EACCESS | AT_SYMLINK_NOFOLLOW).
Accept AT_SYMLINK_NOFOLLOW and use it to control whether symlinks are followed during the path lookup.