Skip to content

Add workaround for recent thinlto test failures #26507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Mar 20, 2026
+7 −4
Merged

Add workaround for recent thinlto test failures #26507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,7 @@ jobs:
lto0.test_exceptions_allowed_uncaught
lto0.test_longjmp_standalone_standalone
lto0.test_embind_i64_val
thinlto0.test_pthread_dlsym
core3
core2g.test_externref
corez.test_dylink_iostream
Expand Down
8 changes: 4 additions & 4 deletions test/codesize/test_codesize_cxx_lto.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"a.out.js": 18562,
"a.out.js.gz": 7668,
"a.out.nodebug.wasm": 101956,
"a.out.nodebug.wasm.gz": 39461,
"total": 120518,
"total_gz": 47129,
"a.out.nodebug.wasm": 101954,
"a.out.nodebug.wasm.gz": 39462,
"total": 120516,
"total_gz": 47130,
"sent": [
"a (emscripten_resize_heap)",
"b (_setitimer_js)",
Expand Down
2 changes: 2 additions & 0 deletions tools/system_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,8 @@ class libc(MuslInternalLibrary,

def __init__(self, **kwargs):
self.non_lto_files = self.get_libcall_files()
# TODO(https://github.com/emscripten-core/emscripten/issues/26506)
self.non_lto_files.append(utils.path_from_root('system/lib/libc/musl/src/locale/uselocale.c'))
super().__init__(**kwargs)

def get_libcall_files(self):
Expand Down
Loading