Skip to content

NXT-14013: Update sizes for largeText for MediaOverlay --> VideoPlayer#345

Open
daniel-stoian-lgp wants to merge 11 commits into
developfrom
feature/NXT-14013
Open

NXT-14013: Update sizes for largeText for MediaOverlay --> VideoPlayer#345
daniel-stoian-lgp wants to merge 11 commits into
developfrom
feature/NXT-14013

Conversation

@daniel-stoian-lgp
Copy link
Copy Markdown
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented May 13, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Adapted largeText design for MediaOverlay, PageViews, PopupTabLayout, Slider, Steps, TabLayout, TooltipDecoratorm VideoPlayer;

Resolution

Additional Considerations

  • MediaOverlay: Screenshot tests in normal text mode fail because @lime-mediaoverlay-line-height was changed from 1.3em to 60px . In the new UX guide, in normal mode, font-size is 48px and line-height 60px (their ratio is not 1.3), Also, in largeText, font-size is 58px and line-height 70px, so the proportion changes; For caption and title, the 1.4 ratio between font-size and line-height is kept for both normal an large Text mode.
  • PageViews: Added dedicated font-size for normalText mode which has the same value, but it is needed to isolate the component font-size from ThemeDcorator's font-size
  • Slider: largeText styling was removed as it is very old legacy code and was making the slider height smaller, instead of keeping it the same or making it bigger
  • Steps: largeText is covered by Header or WizardPanels screenshot tests
  • TabLayout: icon sizes will be covered by Icon component update
  • added missing relevant screenshot tests
  • VideoPlayer: @lime-video-feedback-icon-font-size-large is 1.2*@lime-video-feedback-icon-font-size = 1.2*1.25 = 1.5;

Links

NXT-14013

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.86%. Comparing base (316e850) to head (9770858).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #345   +/-   ##
========================================
  Coverage    81.86%   81.86%           
========================================
  Files          153      153           
  Lines         7476     7476           
  Branches      2249     2249           
========================================
  Hits          6120     6120           
  Misses        1048     1048           
  Partials       308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant