NXT-13003: Update focus area of Scroller in case of byEnter#347
Open
dan-ichim-lgp wants to merge 1 commit into
Open
NXT-13003: Update focus area of Scroller in case of byEnter#347dan-ichim-lgp wants to merge 1 commit into
dan-ichim-lgp wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #347 +/- ##
========================================
Coverage 81.86% 81.86%
========================================
Files 153 153
Lines 7477 7479 +2
Branches 2250 2251 +1
========================================
+ Hits 6121 6123 +2
Misses 1048 1048
Partials 308 308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dan-ichim-lgp
force-pushed
the
feature/NXT-13003
branch
from
3cadba3 to
373e30f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
When using focusableScrollbar="byEnter" on a Scroller, the focus highlight was extending over the scrollbar area, causing the two to visually overlap.
Resolution
The focus area is now constrained to the content region only, leaving the scrollbar visually separate. The behavior is correct in both LTR and RTL layouts and updates dynamically if the scrollbar visibility changes.
Additional Considerations
Can be verified by navigating to a Scroller with focusableScrollbar="byEnter" and pressing Enter to activate the text area — the focus highlight should stop at the scrollbar boundary. Screenshot tests have been added to cover this state.
Links
NXT-13003
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)