Fix running Storybook scene directly#2205
Merged
Merged
Conversation
Previously the default value for `Storybook.quest_directory` was `res://scenes/quests/story_quests`. In commit 226ff24 I moved the call to `_enumerate_quests()` (which scans that folder to feast on the quests within) from `_ready()` (which is only called once the node enters the tree – but the Elder wants to check if there are any quests before showing the book) to the setter of the `quest_directory` property. This broke running the scene directly because of a GDScript quirk that it's taken me nearly two years to notice: setters are not called for default values! The StoryQuest Elder only works because it explicitly re-sets the `quest_directory` property rather than relying on the default. Change the default value in the script to empty string. Set it to `res://scenes/quests/story_quests` in storybook.tscn instead.
|
Test build no longer available. |
manuq
approved these changes
May 18, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This is good to know for me as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the default value for
Storybook.quest_directorywasres://scenes/quests/story_quests.In commit 226ff24 I moved the call to
_enumerate_quests()(whichscans that folder to feast on the quests within) from
_ready()(whichis only called once the node enters the tree – but the Elder wants to
check if there are any quests before showing the book) to the setter of
the
quest_directoryproperty.This broke running the scene directly because of a GDScript quirk that
it's taken me nearly two years to notice: setters are not called for
default values!
The StoryQuest Elder only works because it explicitly re-sets the
quest_directoryproperty rather than relying on the default.Change the default value in the script to empty string. Set it to
res://scenes/quests/story_questsin storybook.tscn instead.