pre-commit: Check for images exceeding 4096×4096#2207
Merged
Conversation
Member
Author
|
https://github.com/endlessm/threadbare/actions/runs/25969999412/job/76340189768 failed successfully: #2206 will address these. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/pre-commit-check-for-images-exceeding-4096-4096/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
ad04fec to
17199f2
Compare
Member
Author
1f1cd25 to
d36fa06
Compare
17199f2 to
3ac5b09
Compare
d36fa06 to
cd68d61
Compare
3ac5b09 to
8be31df
Compare
As documented in https://github.com/endlessm/threadbare/wiki/Visual-Style-Guide#image-file-format this is a limitation of mobile GPUs. Check all PNGs, JPEGs and WebPs against this limit using a small Python program using Pillow. Update the GitHub Actions workflow to check out objects from LFS.
8be31df to
7da56a0
Compare
manuq
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented in
https://github.com/endlessm/threadbare/wiki/Visual-Style-Guide#image-file-format
this is a limitation of mobile GPUs.
Check all PNGs, JPEGs and WebPs against this limit using a small Python
program using Pillow.
Update the GitHub Actions workflow to check out objects from LFS.