Grappling hook: Add hook indicators#2215
Open
manuq wants to merge 3 commits into
Open
Conversation
Rename the assets to how they are used in the game. Duplicate the previously named "indicator_down.png" and modify this asset so it looks like a yellow arrow. The red one (which matches the aim indicator around the player) will be used for indicating when something can be hooked.
|
Play this branch at https://play.threadbare.game/branches/endlessm/indicators/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Maintain an array of observers in HookableArea. In the same way as InteractArea. But these are the HookControl nodes that are pointing at this area. Add a marker for the indicator in HookableBox. The fallback that automatically creates the marker 32 pixels above the anchor point seems fine for pins and needles. Resolve #1503
manuq
changed the title
Collaborator
Author
|
I recommend testing this in the following scenes:
recording.webmIt seems to work. The problem I'm still trying to solve is that the indicator stays after throwing. This is noticeable when collecting buttons: recording.webmThe HookControl has a AIMING_PAUSED state and I'm trying to use it, but that state is obviously not being set. |
The last hook control was set to the AIMING_PAUSED state only when hitting a wall or the air. It should pause too while hooking. As before, if the hooked area has a hook control (like the needles), disable this control to "transfer" the aiming to the next one.
Collaborator
Author
|
OK I've found and fixed the issue above. It was indeed a case that was missing setting the control to "aiming paused". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI indicators: Add specific asset for interacting
Rename the assets to how they are used in the game. Duplicate the previously named "indicator_down.png" and modify this asset so it looks like a yellow arrow. The red one (which matches the aim indicator around the player) will be used for indicating when something can be hooked.
Grappling hook: Add hook indicators
Maintain an array of observers in HookableArea. In the same way as InteractArea.
But these are the HookControl nodes that are pointing at this area.
Add a marker for the indicator in HookableBox. The fallback that automatically
creates the marker 32 pixels above the anchor point seems fine for pins and
needles.
Grappling hook: Pause aiming also when hooking
The last hook control was set to the AIMING_PAUSED state only when hitting a
wall or the air. It should pause too while hooking. As before, if the hooked
area has a hook control (like the needles), disable this control to "transfer"
the aiming to the next one.
Resolve #1503