Skip to content

Conversation

@glucard
Copy link
Contributor

@glucard glucard commented Aug 27, 2025

fix(extract_thinker.markdown.markdown_converter): prevent using vision (if set False) after using it as True

loader = DocumentLoaderPyPdf()
llm = LLM(model_name)
markdown_converter = MarkdownConverter(document_loader=loader, llm=llm)

markdown_converter.to_markdown(source_path, vision=True, pages=[1])
markdown_converter.to_markdown(source_path, vision=False, pages=[1]) # Before the fix, this was still executed as vision=True

@enoch3712
Copy link
Owner

Thank you!

@enoch3712 enoch3712 merged commit 66920c9 into enoch3712:main Aug 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants