Skip to content

fix:Error when configuring data sources via environment variables (env) #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix:Error when configuring data sources via environment variables (env) #2924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efbc667
fix:Error when configuring data sources via environment variables (env)
Oct 30, 2025
7741b95
Fix code format issues in connector_manager.py
Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/dbgpt-serve/src/dbgpt_serve/datasource/manages/connector_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from dbgpt.core.awel.flow import ResourceMetadata
from dbgpt.datasource.base import BaseConnector, BaseDatasourceParameters
from dbgpt.util.annotations import Deprecated
from dbgpt.util.configure.manager import _resolve_env_vars
from dbgpt.util.executor_utils import ExecutorFactory
from dbgpt.util.parameter_utils import _get_parameter_descriptions
from dbgpt_ext.datasource.schema import DBType
Expand Down Expand Up @@ -175,6 +176,11 @@ def get_connector(self, db_name: str):
db_name (str): database name
"""
db_config = self.storage.get_db_config(db_name)

pwd = db_config["db_pwd"]
if pwd:
db_config["db_pwd"] = _resolve_env_vars(pwd)

db_type = DBType.of_db_type(db_config.get("db_type"))
if not db_type:
raise ValueError("Unsupported Db Type！" + db_config.get("db_type"))
Expand Down Expand Up @@ -299,6 +305,10 @@ def test_connection(self, request: DatasourceCreateRequest) -> bool:
bool: True if connection is successful.
"""
try:
pwd = request.params["password"]
if pwd:
request.params["password"] = _resolve_env_vars(pwd)

param = self._create_parameters(request)
_connector = self.create_connector(param)
return True
Expand Down