tf-mod2-demo1: Remove hard-coded project name#5
Open
rmatzke1 wants to merge 5 commits intoeric-keller:mainfrom
Open
tf-mod2-demo1: Remove hard-coded project name#5rmatzke1 wants to merge 5 commits intoeric-keller:mainfrom
rmatzke1 wants to merge 5 commits intoeric-keller:mainfrom
Conversation
SLIB53
reviewed
Feb 27, 2025
SLIB53
left a comment
SLIB53
left a comment
There was a problem hiding this comment.
I think it would be easier for others if the line is simply removed. The project field is optional, and will default to what's provided in the provider block. (see https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_firewall#project-1)
Co-authored-by: Akil Krishnan <akil.krishnan.SLIB53@gmail.com>
Co-authored-by: Akil Krishnan <akil.krishnan.SLIB53@gmail.com>
|
Please merge when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed hard-coded project name and updated instructions accordingly.