Sync with upstream (spacebarchat/server)#134
Merged
Conversation
…uild-workflows
…build-workflows
fix: wrong query for self member in mutual guilds
Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Author
Original prompt from Erkin |
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
erkinalp
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with upstream (spacebarchat/server)
Summary
Merges the latest changes from
spacebarchat/server(upstream) into thedefaultbranch. This brings in ~59 upstream commits including:lambert-server, droppedmissing-native-js-functionsextra/admin-api/Message.fillReplies), vanity URLsMerge resolution details:
Message.ts: Added upstream'sfillReplies()static method andtoJSON(shallow)parameter while preserving fork'sreply_idsandwithSignedAttachments. Changed upstream's|| nullto|| undefinedinfillRepliesto match the existingreferenced_message?: Messagetype.messages/index.ts: Removed the inline polyfill block (now handled byMessage.fillReplies()called earlier), preserved fork'spopulateForwardLinks.Translation.ts: Addedas unknown as RequestHandlercast to fix Express v5 type incompatibility withi18next-http-middleware.assets/openapi.jsonandassets/schemas.json: Regenerated by pre-commit hook after merge.Review & Testing Checklist for Human
Message.fillRepliesbehavior: The upstream used|| nullbut I changed to|| undefinedto satisfy thereferenced_message?: Messagetype. Confirmundefinedbehaves correctly downstream (intoJSON, gateway dispatch, and client rendering of replies).toJSONoutput completeness: The mergedtoJSONnow includesreply_ids(fork),pinned,thread,referenced_message(upstream). Verify no fields are missing or duplicated vs. what clients expect.as unknown as RequestHandlercast works at runtime but masks a real type mismatch betweeni18next-http-middlewareand Express v5. Verify i18n middleware still functions (test with a non-English locale).populateForwardLinks), custom message routing, and PIN_MESSAGES permission split.Notes