Cosmetic change: Omit .config file extension from -config argument#910
Open
weiss wants to merge 1 commit intoerlware:mainfrom
Open
Cosmetic change: Omit .config file extension from -config argument#910weiss wants to merge 1 commit intoerlware:mainfrom
weiss wants to merge 1 commit intoerlware:mainfrom
Conversation
As per the erl(1) manual, the argument to the -config flag is meant to be "sys" rather than "sys.config" (though both will work). Adjust the start scripts accordingly.
Member
|
Probably not going to accept this because, ironically, it actually adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify
-config sysrather than-config sys.config. This is what the erl(1) manual says, it's what other release generators do, and it saves a few characters on the process command line 😄However, as both
sysandsys.configwill work, this fixes a non-issue, so feel free to just close the PR if you don't like the change.