Draft
Conversation
SergioGasquez
approved these changes
Mar 5, 2026
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM! Only left a few formating suggestions and a questions
| Content in these files is included directly into the .data and .rwtext sections without | ||
| validation. | ||
|
|
||
| Example rwtext_hook.x content: |
Member
There was a problem hiding this comment.
Suggested change
| Example rwtext_hook.x content: | |
| Example `rwtext_hook.x` content: |
| If you need to move code or data that you don't control (e.g., from a third-party | ||
| dependency), you can hook into the `esp-hal` linker scripts. | ||
|
|
||
| - Enable the corresponding config options (`ESP_HAL_CONFIG_USE_RWDATA_LD_HOOK` / `ESP_HAL_CONFIG_USE_RWTEXT_LD_HOOK`) |
Member
There was a problem hiding this comment.
Are these configs already released?
Contributor
Author
There was a problem hiding this comment.
No - we need to wait with merging and/or publishing until esp-rs/esp-hal#5116 is merged (or even released)
Member
|
We merged this is esp-hal, I think we should document this but stress its unstable in search of a longer term solution. |
MabezDev
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a chapter about moving code / data to RAM
This shouldn't get merged / published before esp-rs/esp-hal#5116