feat: Add lilygo_t_display_p4 board support#56
Conversation
|
sha=fd45798d41c1b8f9e4d133fb0797041fa0853ebc |
|
Thank you for your PR! We are currently going through our internal merge process. |
@laride Currently, the ES8311 audio initialization on At the moment, when I would like to modify
This would allow ES8311 DAC to work with Would this approach be acceptable, or do you have a better suggestion? |
I noticed that this PR introduces a new Python file to handle a development board with a different configuration variant. We may need to discuss within this PR how similar scenarios should be handled going forward. |
@laride |
|
Thanks for the clarification. We would prefer to have a more generic solution for this kind of scenario, so that similar cases from other vendors can follow a unified approach and documentation in the future. In addition, if we customize this Python script for a specific board, it becomes difficult for us to add build coverage for the board in CI. This would also prevent these boards from being integrated into the online flashing workflow. The Board Manager engineers are currently discussing a suitable long-term solution for handling this type of board-specific customization. Because of that, this PR may need some more time before it can be merged. |
|
@laride I will patiently wait for the results of your discussion regarding the long-term generic solution. Once you have finalized the unified approach and clarified the required adjustments, please feel free to let me know, and I will modify or update the implementation accordingly based on the new requirements. |
Description
Adapt to the new board lilygo_t_display_p4
Refer to the lilygo_t_display_p4 README for usage instructions.
Related
N/A
Testing
Compiled successfully, flashed and tested, everything works properly. Packaged firmware file: [T-Display-P4_v1.0][edge_agent]_firmware_202605080938
Checklist
Before submitting a Pull Request, please ensure the following: