Skip to content

Conversation

@fermino
Copy link

@fermino fermino commented Nov 30, 2025

I noticed a typo in the comments of tools/cmake/project.cmake referencing EXTRA_COMPONENT_DIRS, this fixes it.

It's nothing critical at all but it threw me off while digging through the code so here it is :)


Note

Corrects comment in tools/cmake/project.cmake to reference EXTRA_COMPONENT_DIRS consistently.

Written by Cursor Bugbot for commit 1a6e262. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello fermino, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 1a6e262

@github-actions github-actions bot changed the title Fix typo in cmake docs for EXTRA_COMPONENT_DIRS Fix typo in cmake docs for EXTRA_COMPONENT_DIRS (IDFGH-16884) Nov 30, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 30, 2025
This fixes a typo in a comment that references EXTRA_COMPONENT_DIRS in
project.cmake.
Copy link
Collaborator

@fhrbata fhrbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fermino , thank you for the fix! I left one comment that we should probably also remove the COMPONENTS_DIRS variable too. Otherwise LGTM. Thank you!

# call later using external COMPONENT_DIRS, COMPONENTS_DIRS, EXTRA_COMPONENTS_DIR,
# EXTRA_COMPONENTS_DIRS, COMPONENTS, EXLUDE_COMPONENTS, TEST_COMPONENTS,
# TEST_EXLUDE_COMPONENTS, TESTS_ALL, BUILD_TESTS
# call later using external COMPONENT_DIRS, COMPONENTS_DIRS, EXTRA_COMPONENT_DIRS,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fermino , I think we can also remove the COMPONENTS_DIRS variable, because I don't see it used anywhere in the build system. It seems only COMPONENT_DIRS is supported. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants