Skip to content

Conversation

@KaeLL
Copy link
Contributor

@KaeLL KaeLL commented Dec 10, 2025

SPI component is overly verbose about its
handling of pre-DMA cache<->memory
synchronization. This commit moves the logs to
verbose level, as it seems to fit the criteria
for it
.
Also
Screenshot From 2025-12-09 20-58-34

Yeah!


Note

Demotes specific SPI DMA and cache msync logs from DEBUG to VERBOSE to reduce log noise.

  • Logging:
    • Demote SPI DMA buffer alignment message in components/esp_driver_spi/src/gpspi/spi_master.c from ESP_EARLY_LOGD to ESP_EARLY_LOGV.
    • Demote cache range validity message in components/esp_mm/esp_cache_msync.c from ESP_EARLY_LOGD to ESP_EARLY_LOGV.

Written by Cursor Bugbot for commit 59933e1. This will update automatically on new commits. Configure here.

@KaeLL KaeLL changed the title chore: declutter SPI DMA debug logs Declutter log from overly verbose SPI DMA logging Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KaeLL, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 59933e1

SPI component is overly verbose about its
handling of pre-DMA cache<->memory
synchronization. This commit moves the logs to
verbose level.
@KaeLL KaeLL force-pushed the spi_dma_logs_d_to_v branch from d5395d0 to 59933e1 Compare December 10, 2025 00:52
@github-actions github-actions bot changed the title Declutter log from overly verbose SPI DMA logging Declutter log from overly verbose SPI DMA logging (IDFGH-16940) Dec 10, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 10, 2025
@suda-morris
Copy link
Collaborator

sha=59933e16b5db033c1b0e892047c28ff65070c9d3

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Dec 10, 2025
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants