Native: Allow files arrangement in multiple files#2516
Native: Allow files arrangement in multiple files#2516sudeeptarlekar wants to merge 6 commits intoesrlabs:native-uifrom
Conversation
fda9687 to
138eccb
Compare
1a075bc to
c00ab6a
Compare
|
@AmmarAbouZor can you please review? Thanks in advance :) |
In legacy version of Chipmunk, while loading multiple files user can rearrange the order by dragging them around. This feature was missing from the NativeUI and this commit fixes that missing feature.
098d6ae to
1be5c31
Compare
AmmarAbouZor
left a comment
There was a problem hiding this comment.
The changes are solid. However, I think we need to reconsider the decision to remove the color completely from source items and retrieve the color in render loop as items can go out of sync on multiple edge cases.
Like for now the if you disable one of the sources in the middle then the colors in segments in side view will not match the colors of items in the table (see snapshot)
I think saving the color with source items will keep the logic in one place. It would need to reassign the colors of sources on sort changes but it will keep the logic centered in one place instead of spreading the index logic everywhere and having to deal with edge-cases that we didn't count for
0ffab95 to
40c1a11
Compare
In legacy version of Chipmunk, while loading multiple files user can rearrange the order by dragging them around. This feature was missing from the NativeUI and this commit fixes that missing feature.