Skip to content

Native: Allow files arrangement in multiple files#2516

Open
sudeeptarlekar wants to merge 6 commits intoesrlabs:native-uifrom
sudeeptarlekar:task/tool-649/add_multipl_file_redordering
Open

Native: Allow files arrangement in multiple files#2516
sudeeptarlekar wants to merge 6 commits intoesrlabs:native-uifrom
sudeeptarlekar:task/tool-649/add_multipl_file_redordering

Conversation

@sudeeptarlekar
Copy link
Copy Markdown
Contributor

In legacy version of Chipmunk, while loading multiple files user can rearrange the order by dragging them around. This feature was missing from the NativeUI and this commit fixes that missing feature.

@sudeeptarlekar sudeeptarlekar force-pushed the task/tool-649/add_multipl_file_redordering branch from fda9687 to 138eccb Compare April 13, 2026 14:20
@sudeeptarlekar sudeeptarlekar force-pushed the task/tool-649/add_multipl_file_redordering branch 4 times, most recently from 1a075bc to c00ab6a Compare April 30, 2026 13:10
@sudeeptarlekar
Copy link
Copy Markdown
Contributor Author

@AmmarAbouZor can you please review?

Thanks in advance :)

In legacy version of Chipmunk, while loading multiple files
user can rearrange the order by dragging them around. This feature
was missing from the NativeUI and this commit fixes that missing
feature.
@sudeeptarlekar sudeeptarlekar force-pushed the task/tool-649/add_multipl_file_redordering branch from 098d6ae to 1be5c31 Compare May 4, 2026 09:36
Copy link
Copy Markdown
Member

@AmmarAbouZor AmmarAbouZor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are solid. However, I think we need to reconsider the decision to remove the color completely from source items and retrieve the color in render loop as items can go out of sync on multiple edge cases.

Like for now the if you disable one of the sources in the middle then the colors in segments in side view will not match the colors of items in the table (see snapshot)

I think saving the color with source items will keep the logic in one place. It would need to reassign the colors of sources on sort changes but it will keep the logic centered in one place instead of spreading the index logic everywhere and having to deal with edge-cases that we didn't count for

Image

@sudeeptarlekar sudeeptarlekar force-pushed the task/tool-649/add_multipl_file_redordering branch from 0ffab95 to 40c1a11 Compare May 4, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants