triedb/pathdb: fix off-by-one for last state history ID and handle empty ranges #33103
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
Nov 6, 2025
triedb/pathdb/history_inspect.go
Outdated
| } | ||
| // Make sure the range is valid | ||
| if first >= last { | ||
| if first > last { |
Member
There was a problem hiding this comment.
first == last is allowed for querying single item
Contributor
Author
There was a problem hiding this comment.
first == last is allowed for querying single item
added test
Member
There was a problem hiding this comment.
What I meant is you shouldn't change the condition here.
Please revert to first >= last
Contributor
Author
There was a problem hiding this comment.
What I meant is you shouldn't change the condition here. Please revert to
first >= last
sorry for misunderstanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State history uses 1-based IDs, and rawdb.ReadStateHistory maps an ID to the ancient index by subtracting one (id-1). Therefore, the last ID equals the number of ancient items (head), not head-1.
Using last := head - 1 incorrectly treats Ancients() as the last 0-based index, which causes:
The corrected logic aligns with 1-based ID semantics used across pathdb (e.g., oldest ID is tail+1) and with rawdb’s accessor contracts.