eth/downloader: Guards against division by zero #33159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucia-w
commented
Nov 12, 2025
lucia-w
commented
- We need to check if q.resultSize is not 0 before dividing by q.resultSize
jwasinger
reviewed
Nov 12, 2025
| } | ||
| // Using the newly calibrated result size, figure out the new throttle limit | ||
| // on the result cache | ||
| throttleThreshold := uint64((common.StorageSize(blockCacheMemory) + q.resultSize - 1) / q.resultSize) |
Contributor
There was a problem hiding this comment.
It appears we stop early if there are no completed items (line 298). Can you explain how resultSize would be 0 here?
Contributor
Author
There was a problem hiding this comment.
Nice catch, thank you for your question. But that early return only fires in non-blocking mode: !block.
In the blocking mode, is it possible that when Close is called before any fetch result finishes, the loop breaks?
Contributor
There was a problem hiding this comment.
No. in blocking mode we will wait until there are results on line 315
Contributor
|
Appears to be AI-generated and not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.