Conversation
|
fyi in SH there was some issue with this line: In your o.py extension I changed to (also when we were using |
|
For the lib segment there is an explicit splat setting for the lib directory (rather than using the build_dir). You can do a simple |
|
Ah right, guess for us lib_dir had just defaulted to repo root then.
Makes sense, I don't mind adding a copy to the build dir for it, was just a bit surprised that using ../ wasn't seeming to have any affect at all, can't really see what would even be stopping that, odd. |
|
could you bump the version (there's 3 places, you can find/replace it) and add to the changelog? |
docs/Segments.md
Outdated
|
|
||
| ```yaml | ||
| # link to .text of myobject.o | ||
| - [auto, o, myobject] |
There was a problem hiding this comment.
I don't think recommending auto for this segment type would be a great idea, because it could mess up the size calculation of the previous subsegment. This can be problematic if people wants to disassemble the previous subsegment while linking this object.
src/splat/__init__.py
Outdated
|
|
||
| # Should be synced with pyproject.toml | ||
| __version__ = "0.38.0" | ||
| __version__ = "0.38.1" |
There was a problem hiding this comment.
This introduces a new feature so this should be bumped to 0.39.0 instead of just a patch bump
docs/Segments.md
Outdated
|
|
||
| ## `o` | ||
|
|
||
| Similar to the `lib` segment but used to reference an object file (for example extracted from a shared library file). Does not extract anything from the input binary. |
There was a problem hiding this comment.
It would be nice to mention that this segment can only be used as a subsegment and not as a top-level segment.
Also, where is the object expected to be? In the build folder? Relative to the src, asm, lib, etc folder?
Maybe we should introduce a new setting for this? Something like o_path
If there's a way to do this already im all ears.. but this is more granular than using the
libsegment (and I am struggling to link against libultra.a in a piecemeal fashion, so just wanted to cherry-pick individual objects from it)