Open
Conversation
AngheloAlf
reviewed
Mar 10, 2026
CHANGELOG.md
Outdated
|
|
||
| ### 0.38.1 | ||
|
|
||
| * Fix `bss_size` being required for parent segments that contain `.bss` sections. |
Collaborator
There was a problem hiding this comment.
I think we should somehow mention this is for .bss and not bss
Collaborator
Author
|
Hmm with this change user is now hitting the next error: splat config is - name: scmanager
type: code
start: 0x0406D0
vram: 0x800A1980
subsegments:
- [0x0406D0, c, sc/scmanager]
- [0x041DC0, .data, sc/scmanager]
- [0x042F30, .rodata, sc/scmanager]
- { start: auto, type: .bss, name: sc/scmanager }should the if (
isinstance(ret.vram_start, int)
and isinstance(parent.vram_end, int)
and ret.vram_start >= parent.vram_end # greater than?
):
log.error(
f"The section '{ret.name}' (vram 0x{ret.vram_start:08X}) is outside its parent's address range '{parent.name}' (0x{parent.vram_start:08X} ~ 0x{parent.vram_end:08X}).\n This may happen when the specified `bss_size` value is too small."
) |
Collaborator
|
The current check is correct. Vram addresses are considered "inclusive start, exclusive end". As in: if options.opts.ld_bss_is_noload and isinstance(ret, CommonSegBss) and not ret.type.startswith("."):
# We need to know the bss space for the segment.
if isinstance(parent, CommonSegCode):
if parent.bss_size <= 0:
log.error(idk if this would hit another issue afterwards tho |
AngheloAlf
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.