Fix: default value argument in jinja template causing errors #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng variables (for real this time)
Owner
|
tests failing i see |
Author
|
Not sure if this is a python version issue. I'm running 3.11.3. Here is a trace of it on my end, without my fix: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the jinja template (body.j2) is used to render the functions made available by the MCP server, there is a default value argument which is referenced in the template.
When this argument is a boolean or int, everything is fine. But for string args which have a default value, the quotes don't get added around the value leading to a NameError.
To reproduce: