update systemd service file#310
Closed
deathtrip wants to merge 1 commit intoevilsocket:masterfrom
deathtrip:patch-1
Closed
update systemd service file#310deathtrip wants to merge 1 commit intoevilsocket:masterfrom deathtrip:patch-1
deathtrip wants to merge 1 commit intoevilsocket:masterfrom
deathtrip:patch-1
Conversation
It's better to let directory creation be handled by packaging, instead of executing it on every daemon start. On Arch Linux that directory is already contained in the package. When that line is removed `PermissionsStartOnly=true` can go as well, it's [deprecated](systemd/systemd#10802) anyway.
|
FWIW, this should be doable in Debian packaging too most easily/directly via (I had a similar "huh, that's interesting" moment while reviewing this service file recently 😄) |
Collaborator
|
The PR can not be accepted as is, because we'd break non-arch installations. I think that this task should be done from the daemon, otherwise we'll depend on the service manager used by the distro (systemd, sysv, s6, openrc, etc, etc) |
Contributor
Author
|
I don't think removing these lines would break opensnitch. As right now on non-systemd distros, the rules directory still has to be created some other way. |
Contributor
Author
|
As it's superseded by #1019, i'm gonna close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to let directory creation be handled by packaging, instead of executing it on every daemon start. On Arch Linux for example, that directory is already contained in the package.
When that line is removed
PermissionsStartOnly=truecan go as well, it's deprecated anyway.