-
Notifications
You must be signed in to change notification settings - Fork 17
Some misc README cleanup #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lrettig
wants to merge
3
commits into
master
Choose a base branch
from
lrettig-patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # geth + Wagon | ||
|
|
||
| **NOTE: this client currently is not supported fully and the instructions here may be wrong.** | ||
|
|
||
| [Wagon](http://github.com/go-interpreter/wagon) is a third-party WebAssembly VM written natively in Go. Support for geth + Wagon on the Ewasm testnet is experimental. This document describes how to run geth node with geth and the Wagon VM. | ||
|
|
||
| 1. Get the code from the PR | ||
|
|
||
| ```sh | ||
| > go get github.com/ethereum/go-ethereum | ||
| > cd $GOROOT/src/github.com/ethereum/go-ethereum | ||
| > git remote add gballet git@github.com:gballet/go-ethereum.git | ||
| > git fetch gballet add-ewasm | ||
| > git checkout add-ewasm | ||
| ``` | ||
|
|
||
| 1. Build geth | ||
|
|
||
| ```sh | ||
| > go build ./cmd/geth/... | ||
| ``` | ||
|
|
||
| 1. Run geth | ||
|
|
||
| The Ewasm interpreter will be activated by default as long as you do not specify a `--vm.ewasm=...` on the command line option. | ||
|
|
||
| ```sh | ||
| > TMPDIR=/tmp/ewasm-node/ ./geth --datadir $TMPDIR --etherbase 031159dF845ADe415202e6DA299223cb640B9DB0 --rpc --rpcapi "web3,net,eth,debug" --rpcvhosts="*" --rpcaddr "0.0.0.0" --rpccorsdomain "*" --mine --miner.threads 1 --nodiscover --networkid 66 | ||
| ``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it better to split these two instructions? It seems weird that this block only contains extra options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the
gethconfiguration specified at line 174? Because there's a difference between running a node locally and running a node that syncs the testnet -- these additional commands are intended for testnet syncing. (Though I think--etherbasecould be removed)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of "running a node locally" without connecting to the testnet?
FYI running the node locally can be done in "test" mode which avoids 90% of the commandline options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local development.
Okay. Presumably we still need the
--vm.ewasmflag but not the RPC-related ones?