[PlatformManager] pmUnitVersion support for versionedPmUnitConfigs#1065
Open
aalamsi22 wants to merge 1 commit intofacebook:mainfrom
Open
[PlatformManager] pmUnitVersion support for versionedPmUnitConfigs#1065aalamsi22 wants to merge 1 commit intofacebook:mainfrom
aalamsi22 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Platform manager has a versionedPmUnitConfigs attribute, which allows certain pmUnit configs to be overridden. However, it is only limited to changes "Product Sub-Version".
This proposal adds support for all 3 version attributes in meta-eeprom to be used in versionedPmUnitConfigs. To do that, the
PmUnitVersionstruct is used as suggested by the TODO comment in the thrift config.Test Plan
Manual Testing of The Feature
We will be working with these set of versions on the SMB pmunit
No versionedPmUnitConfigs present
Testing versionedPmUnitConfigs with a duplicated SMB pmunit but removing
SMB_CPLD. SettingproductSubVersionset to 2 (NOT MATCHING).Setting
productSubVersionset to 4 (MATCHING).Using
PmUnitVersionsetting to random version below (NOT MATCHING).Updating
PmUnitVersionto match SMB idprom (MATCHING)