aarch64: Fix JIT for PIE builds #9666
Open
+16
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On aarch64, jitted code ends up segfaulting on PIE HHVM builds. Running a debug build pointed to `makeTarget32` receiving a 64-bit pointer instead of the expected 32-bit pointer, so rework affected usages to operate on 64-bit pointers and registers instead. x86 is not affected by this issue because it presumably makes no equivalent assumption about pointer sizing.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D86880227. (Because this pull request was imported automatically, there will not be any future comments.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On aarch64, jitted code ends up segfaulting on PIE HHVM builds. Running a debug build pointed to
makeTarget32receiving a 64-bit pointer instead of the expected 32-bit pointer, so rework affected usages to operate on 64-bit pointers and registers instead.x86 is not affected by this issue because it presumably makes no equivalent assumption about pointer sizing.