not expand TypeAlias in reveal_type #1437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you elaborate on your proposed fix? I don't think this PR addresses the root cause of #1219 - the type aliases are expanded in |
Contributor
Author
at least less noisy now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1219.
Added TypeAlias::body_type/runtime_value and used them across the solver so we can keep alias names for printing while still acting on their underlying types when needed (attribute access, class bases, isinstance/issubclass, subset checks). Scoped type aliases still behave as TypeAliasType at runtime; legacy aliases now behave like the types they wrap.
Refined isinstance handling so union aliases (e.g., X = B | C) are accepted as class info, and ensured scoped aliases still error.
Allowed type-alias bases when they’re legacy aliases and kept the explicit error for scoped aliases.