Inline true in ReactDelegate.isFabricEnabled initializer (#56859)#56859
Closed
mdvacca wants to merge 1 commit into
Closed
Inline true in ReactDelegate.isFabricEnabled initializer (#56859)#56859mdvacca wants to merge 1 commit into
mdvacca wants to merge 1 commit into
Conversation
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105231216. |
meta-cla
Bot
added
the
CLA Signed
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 15, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
meta-codesync
Bot
changed the title
mdvacca
force-pushed
the
export-D105231216
branch
from
2350c0d to
41db94e
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 15, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 18, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
force-pushed
the
export-D105231216
branch
from
41db94e to
a7af6be
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 18, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 18, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 18, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
force-pushed
the
export-D105231216
branch
from
a7af6be to
5154f46
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
force-pushed
the
export-D105231216
branch
from
5154f46 to
863a5c2
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
force-pushed
the
export-D105231216
branch
from
863a5c2 to
b94190f
Compare
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
force-pushed
the
export-D105231216
branch
from
b94190f to
13c9aff
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
|
This pull request has been merged in ecf0f2d. |
Collaborator
|
This pull request was successfully merged by @mdvacca in ecf0f2d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()flag is being deleted; it always returns true on the canary release stage. The default initializer ofReactDelegate.isFabricEnabledreads the flag — change it totruedirectly.The field itself is preserved because it can be set by the deprecated
(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)constructor that lets callers override the default.Behavior is unchanged.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D105231216