feat(compiler): clarify preserve-manual-memoization error for forward…

[Rithvik914]

… references

Improve diagnostic when a callback (useCallback/useMemo) depends on a memoized value declared later in the component. Adds explicit guidance to declare memoized values before callbacks that capture them and includes the dependency identifier when available.

Changes:

• Enhance message in ValidatePreservedManualMemoization.ts (StartMemoize visitor) to add declaration-order hint and actionable fix suggestion.
• Update existing snapshot: error.false-positive-useMemo-overlap-scopes.expect.md to reflect new wording.
• Add new failing fixture & snapshot: error.useCallback-references-later-useMemo.* (demonstrates forward reference error)
• Add new passing fixture & snapshot: useCallback-after-useMemo-declared.* (proves correct order is accepted)

Testing:

• Snap runner executed; new fixtures behave as expected.
• Overall compiler tests previously at 1786 total with unrelated failures retained; targeted fixtures pass.

Rationale:
Clearer messaging reduces confusion around declaration order vs dependency inference, speeding developer remediation.

Summary

How did you test this change?

[meta-cla]

Hi @Rithvik914!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!