Skip to content

Conversation

@shamkarthik
Copy link

@shamkarthik shamkarthik commented Mar 2, 2025

Pull Request Template

Summary

  • Briefly describe the changes made in this pull request:
    • This pull request updates the GitHub Actions workflow to build either a Debug or Release version of the Ocean Android libraries and third-party dependencies, and uploads them as downloadable artifacts.

Changes

  • Description of the changes made in this pull request:
    • Updated the workflow file to build either a debug or release configuration (one at a time).
    • Configured absolute build directory paths under the GitHub workspace to ensure proper read/write access.
    • Added steps to build the third-party dependencies using build_thirdparty_android.sh.
    • Added steps to build the Ocean Android libraries using build_ocean_android.sh.
    • Introduced archive steps to compress the built libraries into separate artifacts for the chosen build configuration.
    • Added artifact upload steps using actions/upload-artifact@v4 for both third-party dependencies and Android libraries.
    • Added ABI selection input, making the target ABI configurable.
    • Made the build configuration (debug or release) configurable through workflow inputs (only one configuration is built per run).

Motivation

  • Explain the motivation behind making these changes:
    • To streamline the build process by automatically generating artifacts for the chosen build configuration.
    • To facilitate easier integration into external projects by providing downloadable build artifacts directly from the CI/CD pipeline.

Testing

  • Description of the testing performed to verify the changes:
    • Executed the updated workflow on a test branch to ensure that the specified build (debug or release) completes successfully.
    • Verified that the build directories are correctly created and have proper permissions.
    • Confirmed that the artifacts for both third-party dependencies and the Android libraries are archived and uploaded correctly.
    • Manually downloaded and inspected the artifacts to validate their integrity and contents.

Checklist

  • Confirm that the following have been completed:
    • Code compiles and runs successfully on all supported platforms.
    • All tests pass.
    • Documentation is updated (if applicable).
    • Changes follow the project's coding standards.

Additional Comments

  • Additional comments or information that may be helpful:
    • Future improvements might include caching build dependencies to reduce build times.
    • The ABI support is fully configurable, allowing for additional Android ABIs if needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 2, 2025
@shamkarthik
Copy link
Author

image

@shamkarthik shamkarthik marked this pull request as ready for review March 2, 2025 07:49
made the workflow trigger based and added abi and build type configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants