work on Windows #9
Open
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasterthanlime
added a commit
that referenced
this pull request
Dec 11, 2025
Make executable bit handling conditional on Unix platforms: - Add #[cfg(unix)] to PermissionsExt import - Make Job.executable field Unix-only - Conditionally check/set executable bits only on Unix - On Windows, skip executable bit checks entirely Co-authored-by: boringcactus <[email protected]>
4 tasks
fasterthanlime
added a commit
that referenced
this pull request
Dec 11, 2025
* Add pre-push subcommand and update dependencies - Implement `pre-push` subcommand that runs targeted checks on modified crates - Detects changed files since merge-base with origin/main - Identifies affected crates from file paths - Runs clippy, tests, and doc-tests only for affected crates - Provides clear, colorized output for check results - Update dependencies: - fs-err: 3.1.0 -> 3.2.0 - log: 0.4.27 -> 0.4.29 - owo-colors: 4.2.1 -> 4.2.3 - Update GitHub Actions: - actions/checkout: v5 -> v6 - github/codeql-action: v3 -> v4 Resolves facet-rs/facet#1247 * Add Windows compatibility (merge PR #9) Make executable bit handling conditional on Unix platforms: - Add #[cfg(unix)] to PermissionsExt import - Make Job.executable field Unix-only - Conditionally check/set executable bits only on Unix - On Windows, skip executable bit checks entirely Co-authored-by: boringcactus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this looks a little bit uglier with cfg-if, but I’m not the one whose taste matters the most, so I can swap that in if you’d prefer.