Conversation
It was changed in facultyai#180 which broke direct `Project` creation.
Contributor
|
LGTM, modulo getting the test to pass. |
Member
Author
|
@acroz done! |
acroz
approved these changes
May 13, 2022
Contributor
|
@imrehg I've released this to PyPI as 0.30.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was changed in #180 which broke direct
Projectcreation, that is0.27.2if this library.Noticed because since that version the
faculty-clitests are not passing, instead currently throwing an error:Testing it locally with:
python -c "import uuid; from faculty.clients.project import Project; Project(id=uuid.uuid4(), name='test-project', owner_id=uuid.uuid4())"NB: need #200 for linting to correctly pass here.
Also this should be a short term / temporary change, and extra work stemming from #197 (followed up in #199) should fix this differently over the long run. The test change within this PR should protect against future issue like this.