fix: add ?bundle parameter to esm.sh CDN URLs #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this week, esm.sh/@farcaster/miniapp-sdk URLs without the ?bundle parameter have stopped working. Adding the ?bundle query string resolves the issue and ensures the SDK continues to load correctly from the CDN. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
|
@TimDaub is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
?bundlequery parameter to all esm.sh CDN imports of@farcaster/miniapp-sdkDetails
Since this week, importing from
https://esm.sh/@farcaster/miniapp-sdkwithout the?bundleparameter has stopped working. Adding the?bundlequery string resolves the issue and ensures the SDK continues to load correctly from the CDN.Changes
Updated two documentation files:
site/pages/docs/getting-started.mdxsite/pages/docs/sdk/quick-auth/index.mdxBoth now use
https://esm.sh/@farcaster/miniapp-sdk?bundleinstead of the plain URL.🤖 Generated with Claude Code