fix(audio): clean up retained recordings#5240
Open
ComputelessComputer wants to merge 1 commit into
Open
Conversation
Delete orphaned recorder artifacts during retention cleanup and refresh cached audio state after background deletion.
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete orphaned recorder artifacts during retention cleanup and refresh cached audio state after background deletion.
Note
Medium Risk
Modifies audio retention cleanup to delete additional on-disk artifacts (including orphaned session folders) and adds a new filesystem command, which could unintentionally remove files if the orphan/expiry detection is wrong.
Overview
Audio retention cleanup now removes more disk artifacts and reports what was deleted.
cleanupExpiredAudionow returns deleted session IDs, tracks all known sessions, and calls a new fs-sync command to delete orphaned expired audio directories in addition to deleting inactive expired session audio.UI cache is refreshed after background deletions.
TaskManagerinvalidates the React Queryaudioexistence/url caches for each deleted session so the app stops showing stale audio state.On the fs side, audio deletion now removes additional recorder artifacts (eg
audio.mp3.tmp,audio_mic.wav,audio_spk.wav), addsaudio_delete_orphaned_expired(with permissions + generated TS bindings), and includes new unit tests covering orphan deletion and artifact removal.Reviewed by Cursor Bugbot for commit 2d1f5e2. Bugbot is set up for automated code reviews on this repo. Configure here.