Skip to content

fix(stt): pass speaker count hints#5241

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/speaker-count-hints
May 19, 2026
Merged

fix(stt): pass speaker count hints#5241
ComputelessComputer merged 1 commit into
mainfrom
fix/speaker-count-hints

Conversation

@ComputelessComputer
Copy link
Copy Markdown
Collaborator

@ComputelessComputer ComputelessComputer commented May 18, 2026

Infer participant speaker counts for live and batch STT requests, pass them through Hyprnote proxy URLs, and map them to supported provider diarization parameters.


Note

Medium Risk
Touches STT request construction across desktop, proxy, and multiple provider adapters; incorrect hint mapping could change diarization behavior or break provider requests. Changes are covered by unit tests but still impact a core transcription path.

Overview
Adds speaker-count diarization hints end-to-end. Desktop batch transcription now infers num_speakers from distinct session participants (+ self) via getSessionSpeakerCount when the caller doesn’t explicitly set speaker options.

Live listener params now set ListenParams.num_speakers from distinct participants (provider-agnostic), and AssemblyAI streaming query construction derives speaker_labels/max_speakers from ListenParams speaker fields rather than relying on custom_query.

Hyprnote proxy and client adapters propagate num_speakers/min_speakers/max_speakers through query params and provider-specific request fields (Hyprnote live+batch URLs, Gladia diarization_config, ElevenLabs num_speakers), and the OpenAPI/query parsing are updated accordingly with new tests.

Reviewed by Cursor Bugbot for commit 3ea0efa. Bugbot is set up for automated code reviews on this repo. Configure here.


This is part 1 of 2 in a stack made with GitButler:

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 3ea0efa
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a0bf4656a947000087e1532

Comment thread crates/listener-core/src/actors/listener/adapters.rs
Comment thread crates/owhisper-client/src/adapter/assemblyai/live.rs
Comment thread crates/listener-core/src/actors/listener/adapters.rs Outdated
@ComputelessComputer ComputelessComputer force-pushed the fix/speaker-count-hints branch 2 times, most recently from 4b5d00f to 95fd574 Compare May 19, 2026 05:05
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 95fd574. Configure here.

Comment thread crates/owhisper-client/src/adapter/assemblyai/live.rs
@ComputelessComputer ComputelessComputer force-pushed the fix/speaker-count-hints branch from 95fd574 to 4aab320 Compare May 19, 2026 05:13
Infer participant speaker counts for live and batch STT requests, pass them through Hyprnote proxy URLs, and map them to supported provider diarization parameters.
@ComputelessComputer ComputelessComputer force-pushed the fix/speaker-count-hints branch from 4aab320 to 3ea0efa Compare May 19, 2026 05:25
@ComputelessComputer ComputelessComputer merged commit 2c72928 into main May 19, 2026
13 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/speaker-count-hints branch May 19, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant