fix(stt): pass speaker count hints#5241
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
4e98b63 to
af049f4
Compare
af049f4 to
8e75bbb
Compare
4b5d00f to
95fd574
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 95fd574. Configure here.
95fd574 to
4aab320
Compare
Infer participant speaker counts for live and batch STT requests, pass them through Hyprnote proxy URLs, and map them to supported provider diarization parameters.
4aab320 to
3ea0efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Infer participant speaker counts for live and batch STT requests, pass them through Hyprnote proxy URLs, and map them to supported provider diarization parameters.
Note
Medium Risk
Touches STT request construction across desktop, proxy, and multiple provider adapters; incorrect hint mapping could change diarization behavior or break provider requests. Changes are covered by unit tests but still impact a core transcription path.
Overview
Adds speaker-count diarization hints end-to-end. Desktop batch transcription now infers
num_speakersfrom distinct session participants (+ self) viagetSessionSpeakerCountwhen the caller doesn’t explicitly set speaker options.Live listener params now set
ListenParams.num_speakersfrom distinct participants (provider-agnostic), and AssemblyAI streaming query construction derivesspeaker_labels/max_speakersfromListenParamsspeaker fields rather than relying oncustom_query.Hyprnote proxy and client adapters propagate
num_speakers/min_speakers/max_speakersthrough query params and provider-specific request fields (Hyprnote live+batch URLs, Gladiadiarization_config, ElevenLabsnum_speakers), and the OpenAPI/query parsing are updated accordingly with new tests.Reviewed by Cursor Bugbot for commit 3ea0efa. Bugbot is set up for automated code reviews on this repo. Configure here.
This is part 1 of 2 in a stack made with GitButler: