Skip to content

feat(s3): add basePath support for isolated user directories #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neo3k wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(s3): add basePath support for isolated user directories #1636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion fs/s3/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func LoadFs(access *confpar.Access) (afero.Fs, error) {
secretAccessKey := access.Params["secret_access_key"]
disableSSL := access.Params["disable_ssl"] == "true"
pathStyle := access.Params["path_style"] == "true"
basePath := access.Params["basePath"]

// Build config options for AWS SDK v2
var configOpts []func(*config.LoadOptions) error
Expand Down Expand Up @@ -69,5 +70,10 @@ func LoadFs(access *confpar.Access) (afero.Fs, error) {

s3Fs := aferos3.NewFsFromClient(bucket, client)

return s3Fs, nil
var fs afero.Fs = s3Fs
if basePath != "" {
fs = afero.NewBasePathFs(s3Fs, basePath)
}

return fs, nil
}