PF-2068 Use default artifact-name from anchore/sbom-action in lib workflow#326
Open
PF-2068 Use default artifact-name from anchore/sbom-action in lib workflow#326
Conversation
jasaltvik
force-pushed
the
PF-2068-remove-artifact-name-input-to-use-default
branch
from
4a3c035 to
1e124f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if artifact-name is not overridden for library workflows, the name is empty (the input is not currently mandatory: https://github.com/felleslosninger/github-workflows/blob/main/.github/workflows/ci-maven-install-deploy-lib.yml#L31). In these situations, we end up with a borked name for the artifact, and this happens for all workflows that does not override the artifact-name. For our normal Maven builds, we do not have this functionality, which means we use the default from
anchore/sbom-action.