fix tests / remove unused dependency

[drzraf]

• Use tests attributes for phpunit 8 / PHP 8.3
• Remove useless dependency upon the (heavy) symfony/intl package

[flack]

Thanks for the PR!

About the symfony/intl dependency, please see the discussion in #16

[drzraf]

Good point. I changed it that way.

[flack]

@drzraf I think the workaround mentioned in #16 only works in the parent project, i.e. the one which includes ranger, not in the ranger config itself (IIUC what this change would do would be to remove symfony/intl, not matter who exactly required it, so that's not something we would want to do here).

I mean, since you're the second person who stumbled across this issue, maybe we should just remove the intl dependency after all. But it would be nice if we could then at least show a clear error message telling the user how to fix the problem. Because right now, if there's any project using ranger only in English, their code would break the next time they update

[sque89]

Hi @flack, thanks a lot for answering here so quickly.

Not sure if you intended to use semantic versioning with this project. If you do, how about to increase the major version. This would tell consumers of this project that something changed that breaks backward compatibility. In the changelog and readme we would then highlight that ext-intl is now required and the symfony package does not work as a fallback anymore.

Also hopefully every consumer has the major version locked in their dependency tree so that no automatic update will happen that breaks existing projects, but they need to optin to the update checking first what changed.

[sque89]

@flack a quick and hopefully not too intrusive reminder. Thanks!

[flack]

@sque89 yes, I think I'll just do a new version. Since the current major version is 0, according to my knowledge, API breaks are still allowed under semantic versioning. So I'll bump to 0.6 (first such bump since 2019), that should be enough to signal something has changed.

I've just cut a last 0.5.x release, since I noticed gh CI wasn't running. The phpunit changes in this PR have since been added from another source (#18), so this PR will need to be adapted/rebased (or otherwise we do the dependency change in a fresh PR).

[sque89]

Hi @flack, that sounds great thanks! We will rebase the branch to update the PR.

[flack]

Merged, thx!