Skip to content

Add correlationId, taskDomain to scheduled workflows #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomasol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add correlationId, taskDomain to scheduled workflows #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,11 @@ curl -X POST \
"param2": "value2"
},
"fromDate": "2019-01-01T15:04:05Z",
"toDate": "2019-07-01T15:04:05Z"
"toDate": "2019-07-01T15:04:05Z",
"correlationId" "myid",
"taskToDomain": {
"*": "mydomain"
}
}'
```
* Where
Expand All @@ -169,6 +173,8 @@ curl -X POST \
* When a workflow instance is COMPLETED, its output values will be merged to the current schedule workflow context so that these new values will be used on the next workflow instantiation calls as "input".
* This may be useful in cases where your workers want to return data that will be used on following workflow calls. For example, workflow instance 1 will process from date 2019-01-01 to 2019-01-15 and its output will be lastDate=2019-01-15; than instance2 from 2019-01-16 to 2019-02-11 and returns lastDate=2019-02-11 and so on.
* **parallelRuns** - if true, every trigger from timer (according to cron string) will generate a new workflow instance in Conductor. if false, no new workflows will be generated if there are other workflow instances in state RUNNING, so that only one RUNNING instance will be present at a time
* **correlationId** - passed to Conductor when starting a workflow, see https://netflix.github.io/conductor/gettingstarted/startworkflow/
* **taskToDomain** - passed to Conductor when starting a workflow, see https://netflix.github.io/conductor/configuration/taskdomains/

* **GET /schedule**
* Returns a list of schedules
Expand Down
6 changes: 6 additions & 0 deletions schellar/conductor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ func launchWorkflow(scheduleName string) error {
wf["version"] = schedule.WorkflowVersion
wf["input"] = schedule.WorkflowContext
wf["input"].(map[string]interface{})["scheduleName"] = schedule.Name
if len(schedule.CorrelationID) > 0 {
wf["correlationId"] = schedule.CorrelationID
}
if len(schedule.TaskToDomain) > 0 {
wf["taskToDomain"] = schedule.TaskToDomain
}
wfb, _ := json.Marshal(wf)

logrus.Debugf("Launching Workflow %s", wf)
Expand Down
2 changes: 2 additions & 0 deletions schellar/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ type Schedule struct {
FromDate *time.Time `json:"fromDate,omitempty" bson:"fromDate"`
ToDate *time.Time `json:"toDate,omitempty" bson:"toDate"`
LastUpdate time.Time `json:"lastUpdate,omitempty" bson:"lastUpdate"`
CorrelationID string `json:"correlationId,omitempty" bson:"correlationId"`
TaskToDomain map[string]string `json:"taskToDomain,omitempty" bson:"taskToDomain"`
}

func (schedule Schedule) ValidateAndUpdate() error {
Expand Down