Helpers, mullow and modular inverse for radix integers#2561
Merged
fredrik-johansson merged 6 commits intoflintlib:mainfrom Jan 21, 2026
Merged
Helpers, mullow and modular inverse for radix integers#2561fredrik-johansson merged 6 commits intoflintlib:mainfrom
fredrik-johansson merged 6 commits intoflintlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add more essential functionality for radix integers:
This is now starting to get usable for p-adics.
Check out these timings @thofma @fieker.
Multiplication mod$B^n$ where $B = 7^{22}$ (
padic_mul,fmpz_mod_mul,mpn_mod_mul,radix_integer_mullow_limbs):There will be a little less overhead for small$n$ if one uses the mpn-like interface instead of the mpz-like
radix_integer.Inversion of a unit mod$B^n$ where $B = 7^{22}$ :
It remains to implement functions that accept a digit count rather than a limb count. These are more fiddly and will inevitably have some more overhead. In practice, the most efficient way to implement$\mathbb{Z} / p^e \mathbb{Z}$ for specific $e$ (or $\mathbb{Q}_p$ with digit-granular precision) will probably be to actually use whole limbs internally and reduce modulo a fractional limb only when strictly needed, e.g. when doing a comparison.