Skip to content
This repository was archived by the owner on Jun 15, 2024. It is now read-only.

failure_message_when_negated implementation added#4

Open
new23d wants to merge 1 commit intoflosell:masterfrom
new23d:patch-1
Open

failure_message_when_negated implementation added#4
new23d wants to merge 1 commit intoflosell:masterfrom
new23d:patch-1

Conversation

@new23d
Copy link

@new23d new23d commented Sep 1, 2018

failure_message_when_negated is called when a should_not be_allowed_to control fails to pass

failure_message_when_negated is called when a should_not be_allowed_to control fails to pass
@flosell
Copy link
Owner

flosell commented Sep 2, 2018

Hi, thanks for your contribution!

Would you mind adding a unit-test for this? This test would probably be a good example to emulate.

Also, out of curiosity, I would have expected failure_message and failure_message_when_negated to be similar (like they are in the rspec docs). Any reason why you chose to go with an implementation that's more similar to expected?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants