FDN-4546 Alternative name for JWT_SALT

[jackl]

When moving services away from environment provider to SSM, we use idiomatic names for typesafe config keys. JWT_SALT becomes jwt.salt in SSM, as JWT_SALT as a config key name is misleading as it indicates an environment setting. To make it work currently, services set JWT_SALT = ${?JWT_SALT}.

Summary by CodeRabbit

• Chores
  • Enhanced configuration flexibility for JWT authentication handling, allowing optional overrides while maintaining backward compatibility with existing defaults.

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/lib-play/job/PR-644/1/scoverage-report/

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90dcbd3 and f59716f.

📒 Files selected for processing (1)

• lib/app/io/flow/play/controllers/FlowActionInvokeBlockHelper.scala

---

📝 Walkthrough

Walkthrough

Modified jwtSalt initialization in FlowActionInvokeBlockHelper to use an optional jwt.salt configuration parameter with a fallback to the required JWT_SALT environment variable, enabling configuration override while maintaining backward compatibility.

Changes

Cohort / File(s)	Summary
JWT Configuration lib/app/io/flow/play/controllers/FlowActionInvokeBlockHelper.scala	Updated jwtSalt initialization to read from optional jwt.salt config with fallback to JWT_SALT env variable, allowing config-based override while preserving existing defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is partially related to the changeset, referring to a real aspect of the change (alternative name for JWT_SALT), but it is vague and doesn't clearly indicate what the actual change accomplishes or why it matters.	Consider a more descriptive title that explains the practical change, such as 'Support jwt.salt config key alongside JWT_SALT environment variable' or 'Allow jwt.salt config override for JWT salt configuration'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/lib-play/job/PR-644/2/scoverage-report/