feat: add E2E deployment test for Fluentd#1849
Merged
joshuabaird merged 6 commits intofluent:masterfrom Feb 11, 2026
Merged
Conversation
3b92e10 to
88adab9
Compare
Contributor
Author
|
@marcofranssen @joshuabaird please have a look |
414245a to
784c512
Compare
Contributor
Author
|
@marcofranssen @joshuabaird awaiting your review on this one |
Collaborator
|
@ishaanxgupta the test failed itself, see https://github.com/fluent/fluent-operator/actions/runs/21453174637/job/62003022673?pr=1849, please fix it first. Thank you. |
784c512 to
9f4aa55
Compare
- Added E2E deployment test for Fluentd with EmptyDir buffers for CI runners. - Enabled manual triggering (workflow_dispatch) for E2E CI workflows. - Fixed Helm linting by using local dependency paths for unreleased charts. - Tidied Go modules. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
The E2E test was failing because the Fluentd image ghcr.io/fluent/fluent-operator/fluentd:v1.19.1 wasn't available in the Kind cluster. This commit adds the missing step to build the Fluentd image using make build-fd-amd64 and load it into the Kind cluster before running the e2e tests. Resolves ImagePullBackOff error in CI. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
The Fluentd Dockerfile requires FLUENTD_BASE_VERSION to be set, but the Makefile wasn't passing it. This caused builds to fail with 'fluent/fluentd:v-debian: not found'. Now reading the version from cmd/fluent-watcher/fluentd/VERSION file and passing it as --build-arg to match the GitHub workflow behavior. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
9f4aa55 to
e2c4192
Compare
- Trim whitespace from FLUENTD_BASE_VERSION to avoid CRLF issues - Use FD_IMG variable in e2e script to avoid image tag drift - Add comment explaining check-version-increment disable rationale Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
Contributor
Author
|
@cw-Guo tested on local, the tests should pass this time |
Contributor
Author
|
@joshuabaird can we merge this now? |
The file:// dependencies were for local development only and break the published chart for end users. Reverting to remote repository URLs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Josh Baird <jbaird@galileo.io>
c08072e to
04d52ba
Compare
joshuabaird
approved these changes
Feb 11, 2026
Collaborator
joshuabaird
left a comment
There was a problem hiding this comment.
Thanks @ishaanxgupta!
joshuabaird
added a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Feb 13, 2026
* feat(e2e): add Fluentd deployment stability fixes and CI triggers - Added E2E deployment test for Fluentd with EmptyDir buffers for CI runners. - Enabled manual triggering (workflow_dispatch) for E2E CI workflows. - Fixed Helm linting by using local dependency paths for unreleased charts. - Tidied Go modules. Signed-off-by: hemang1404 <hemangsharrma@gmail.com> * fix(e2e): build and load Fluentd image in Kind cluster The E2E test was failing because the Fluentd image ghcr.io/fluent/fluent-operator/fluentd:v1.19.1 wasn't available in the Kind cluster. This commit adds the missing step to build the Fluentd image using make build-fd-amd64 and load it into the Kind cluster before running the e2e tests. Resolves ImagePullBackOff error in CI. Signed-off-by: hemang1404 <hemangsharrma@gmail.com> * fix(build): add FLUENTD_BASE_VERSION build arg for Fluentd image The Fluentd Dockerfile requires FLUENTD_BASE_VERSION to be set, but the Makefile wasn't passing it. This caused builds to fail with 'fluent/fluentd:v-debian: not found'. Now reading the version from cmd/fluent-watcher/fluentd/VERSION file and passing it as --build-arg to match the GitHub workflow behavior. Signed-off-by: hemang1404 <hemangsharrma@gmail.com> * fix(ci): improve build robustness and documentation - Trim whitespace from FLUENTD_BASE_VERSION to avoid CRLF issues - Use FD_IMG variable in e2e script to avoid image tag drift - Add comment explaining check-version-increment disable rationale Signed-off-by: hemang1404 <hemangsharrma@gmail.com> * Revert Chart.yaml dependency changes to use remote repositories The file:// dependencies were for local development only and break the published chart for end users. Reverting to remote repository URLs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Josh Baird <jbaird@galileo.io> --------- Signed-off-by: hemang1404 <hemangsharrma@gmail.com> Signed-off-by: Josh Baird <jbaird@galileo.io> Co-authored-by: hemang1404 <hemangsharrma@gmail.com> Co-authored-by: Josh Baird <jbaird@galileo.io> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test creates a Fluentd CR with FluentdConfig and ClusterOutput, waits for the operator to create a StatefulSet, and verifies that pods are running with all containers ready.
The test:
Executed automatically by the existing
test-e2e.ymlworkflow.Fixes #1733
Collaborated with @hemang1404