test(referencedataset): add unit tests for ConfigMap and DaemonSet operations #5419
Conversation
…erations Signed-off-by: adity1raut <[email protected]>
Summary of ChangesHello @adity1raut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the test coverage for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @adity1raut. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds unit tests for ConfigMap and DaemonSet operations related to referencedataset. The tests cover various scenarios, including different runtime types, existing resources, and missing source resources, which is great.
My review focuses on improving the test code's maintainability by reducing code duplication. I've suggested refactoring the repeated creation of refDataset objects into the BeforeEach blocks. This will not only make the tests cleaner but also fix inconsistencies where some test cases were using incomplete refDataset objects.
| refDataset := &datav1alpha1.Dataset{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "ref-dataset", | ||
| Namespace: "ref-ns", | ||
| UID: types.UID("test-uid"), | ||
| }, | ||
| TypeMeta: metav1.TypeMeta{ | ||
| APIVersion: "data.fluid.io/v1alpha1", | ||
| Kind: "Dataset", | ||
| }, | ||
| } |
There was a problem hiding this comment.
The refDataset object is repeatedly defined across multiple test cases within this Describe block. To improve code maintainability and reduce duplication, consider defining it once in a var block at the Describe scope and initializing it within the BeforeEach function.
This would also help resolve an inconsistency in the test "when source daemonset does not exist", where the refDataset is missing the TypeMeta field, which is used by the function under test to create an OwnerReference.
Example refactoring:
var _ = Describe("ConfigMap Operations", func() {
Describe("copyFuseDaemonSetForRefDataset", func() {
var (
testScheme *runtime.Scheme
testObjs []runtime.Object
fakeClient client.Client
refDataset *datav1alpha1.Dataset
)
BeforeEach(func() {
testScheme = runtime.NewScheme()
// ...
testObjs = []runtime.Object{}
refDataset = &datav1alpha1.Dataset{
ObjectMeta: metav1.ObjectMeta{
Name: "ref-dataset",
Namespace: "ref-ns",
UID: types.UID("test-uid"),
},
TypeMeta: metav1.TypeMeta{
APIVersion: "data.fluid.io/v1alpha1",
Kind: "Dataset",
},
}
})
// ... test cases using refDataset
})
//...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5419 +/- ##
==========================================
- Coverage 57.46% 56.22% -1.24%
==========================================
Files 443 443
Lines 30735 30735
==========================================
- Hits 17661 17282 -379
- Misses 11460 11886 +426
+ Partials 1614 1567 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: adity1raut <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Part Of #5407
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews