Skip to content

feat: support graceful scale-down for AlluxioRuntime using AdvancedStatefulSet#5805

Open
jakharmonika364 wants to merge 1 commit intofluid-cloudnative:masterfrom
jakharmonika364:feat-support-advanced-statefulset-4193
Open

feat: support graceful scale-down for AlluxioRuntime using AdvancedStatefulSet#5805
jakharmonika364 wants to merge 1 commit intofluid-cloudnative:masterfrom
jakharmonika364:feat-support-advanced-statefulset-4193

Conversation

@jakharmonika364
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR implements a graceful decommissioning workflow for Alluxio workers during scale-in. It adds a new AdvancedStatefulSet feature gate that allows Fluid to leverage OpenKruise capabilities for finer pod lifecycle management. When enabled, workers are decommissioned and their cached data is migrated before the pods are terminated, ensuring cluster stability and data availability during scaling operations.

Ⅱ. Does this pull request fix one issue?

fixes #4193

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

  • pkg/ddc/alluxio/operations/decommission_test.go: Unit tests for Alluxio decommissioning commands and active worker count parsing.
  • Integration verified via SyncReplicas logic to ensure scale-down waits for successful decommissioning.

Ⅳ. Describe how to verify it

  1. Enable AdvancedStatefulSet=true in the feature gates.
  2. Deploy an AlluxioRuntime and scale down the replicas.
  3. Verify that the targeted worker pods are decommissioned from the Alluxio master before the StatefulSet actually deletes the pods.

Ⅴ. Special notes for reviews

The feature is currently in Alpha and disabled by default. It provides the necessary infrastructure to support selective pod deletion in later phases.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Apr 23, 2026

Hi @jakharmonika364. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces graceful worker scale-down for Alluxio by decommissioning workers before they are terminated by the StatefulSet controller, ensuring cached blocks can be migrated. This functionality is gated by a new AdvancedStatefulSet feature. The changes include new decommissioning operations in AlluxioFileUtils, integration into the SyncReplicas reconciliation loop, and comprehensive unit tests. Review feedback suggests improving context propagation by replacing context.TODO(), optimizing efficiency by passing existing runtime objects to avoid redundant API lookups, and refining error handling during the draining phase to prevent log noise.

Comment thread pkg/ddc/alluxio/replicas.go
Comment thread pkg/ddc/alluxio/replicas.go
Comment thread pkg/ddc/alluxio/replicas.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 39.80583% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.11%. Comparing base (82e490e) to head (c62bca3).

Files with missing lines Patch % Lines
pkg/ddc/alluxio/replicas.go 11.76% 59 Missing and 1 partial ⚠️
pkg/features/features.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5805      +/-   ##
==========================================
- Coverage   58.17%   58.11%   -0.06%     
==========================================
  Files         478      480       +2     
  Lines       32485    32588     +103     
==========================================
+ Hits        18899    18940      +41     
- Misses      12042    12103      +61     
- Partials     1544     1545       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakharmonika364 jakharmonika364 force-pushed the feat-support-advanced-statefulset-4193 branch from 8c7de5c to b77d0d4 Compare April 23, 2026 20:50
…atefulSet (fluid-cloudnative#4193)

Signed-off-by: Monika Jakhar <jakharmonika364@gmail.com>
@jakharmonika364 jakharmonika364 force-pushed the feat-support-advanced-statefulset-4193 branch from b77d0d4 to c62bca3 Compare April 26, 2026 20:54
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURES] Support Pod-Specific Scaling Down in Fluid using Advanced StatefulSet

1 participant